#SHA-12: fix: breadcrumb hover issue #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #28
Implemented the fix simply by using the nextjs Link as children to each of the breadcrumb children. As the first link ("Home") in each breadcrumb example already had a Link component as a child, I implemented the same thing for each fo the additional links (Support and Account) in each of the following examples where they were missing:
modified: src/registry/default/example/breadcrumb-demo.tsx modified: src/registry/default/example/breadcrumb/breadcrumb-popover.tsx modified: src/registry/default/example/breadcrumb/breadcrumb-separator.tsx modified: src/registry/default/example/breadcrumb/breadcrumb-variants.tsxI also capitalized the
Vin the heading for "Breadcrumb Variants". this affected the doc file at: