Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up: Date time input #43

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

gaurangrshah
Copy link
Collaborator

@gaurangrshah gaurangrshah commented Apr 9, 2024

  • updates jsdocs
  • removes unused imports
  • sorts imports
  • extracts unused naturalLanguage pattern regex matcher.
    • we're not using this internally bc it really doesn't help us in our use case because of the dual input composition pattern we are unable actually validate the input natively in the browser, but it can be useful if someone needs to validate the value afterwards on submit. So i left it in the codebase for their use.
  • Updated the import from chrono-node to only import the parseDate function that we use, which reduced the bundle by over 100k

@BelkacemYerfa BelkacemYerfa merged commit 281f6de into BelkacemYerfa:dev Apr 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants