Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: errors hydration errors + re-adds vscode settings #44

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

gaurangrshah
Copy link
Collaborator

Implements several small fixes:

  • fixes hydration error warning caused by the command component's button element where the icon was rendering a placeholder on the server (Crtl) and the actual icon on the client. I used a useMount pattern to make sure the component doesn't load on the server.
  • removed .vscode/settings.son from .gitignore - this allows us to share linting configurations amongst developers allowing us to ensure better code quality. I also added a few extensions to the recommended extensions array in the file Most of the extensions are related to better handling of errors, typescript, and linting. Just to clarify these are only recommended they will not self install the user still has to manually accept and install them if they want to.

image
image
image

@gaurangrshah gaurangrshah marked this pull request as ready for review April 10, 2024 02:03
@BelkacemYerfa BelkacemYerfa merged commit be777c7 into BelkacemYerfa:dev Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants