Date-time-picker #45
Merged
Date-time-picker #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://linear.app/shadcn-extension/issue/SHA-32/headless-time Implements a datetime picker component using the headless library: timescape. Currently the implementation is working, but need a strategy to make the component re-usable. |
|
So i didn't push this for review because I am trying to solve the issue of how to pass an onChange handler into a client component if it is being exported from the file. Here's a similar error just for the record. I know there's a pattern I've used recently for this, but I think it involves client / server relationships between these components. I'm gonna take a look again today with fresh eyes and see what I come up with. |
…into date-time-picker
…into date-time-picker
|
Updates docs and adds form example using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a datetime picker using timescape.