FIX: Carousel SliderMainItem children components not handling onKeyDown events #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldren components to handle onKeyDown events.
|
Hello @FlorianMgs ! Thank you for addressing this issue for bringing this into our attention, the fix that you made is good, as a consequence you PR will get merge into the dev branch. As a result this fix will be landed in the next release. Welcome to contribution club , as a contributor 💪. Don't forget to spread the word on Reddit or similar. Enjoy 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
event.preventDefault();into thecasestatements.Before that, inputs nested under a
SliderMainItemwere not receiving pressed keys.