Add new constants directory to hold rule configurations #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Thank you for the PR. |
|
If you don't mind just fixing the unused imports from https://github.com/BenBrostoff/draftfast/actions/runs/7263813162/job/19803128017?pr=211 that would be awesome. If they're just imported to be exposed I'm fine doing the |
BenBrostoff
reviewed
Dec 20, 2023
|
Thanks again! Future PRs good anytime :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we could organize the rules a little bit better by introducing a directory that holds all of the static/constant rule configurations.
This is request does not modify any existing imports or logic that affects the package. This just adds new files to be used in followup pull requests