Settings for notifications #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several users have requested the ability to reduce the number of notifications sent via the calendar. This commit adds the ability to globally disable each type of notification: create/post, update/edit, cancel, activate, end.
Closed
This addresses one of the top comments in issues reported to the calendar: allow admins to control when and how often operations are pinged out. Closes BenHUET#22
Allow an empty setting in case an admin wants to disable pings entirely
warlof
requested changes
Jan 1, 2022
src/database/migrations/2021_12_31_213410_default_notification_settings.php
Outdated
Show resolved
Hide resolved
src/database/migrations/2021_12_31_213435_default_ping_operation_settings.php
Outdated
Show resolved
Hide resolved
* Fix boolean value to be actual boolean * Combine two migrations into one and used clearer key/value array for settings
|
@warlof Thank you again for all the feedback. I believe I have addressed all the comments, except the two I responded to above. Can I get another review? |
Instead of using `!!`, rely on the framework to validate the boolean value, then coerce the type before saving. Also, bring the `slack_integration` setting in line with the other checkbox values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several users have requested the ability to reduce the number of notifications sent from the calendar. This commit adds two new setting groups:
First, the ability to globally disable each type of notification: create/post, update/edit, cancel, activate, end. For us, we find the "update" notifications more noisy than helpful, so we disable it as shown in the screenshot.
Second, this adds the ability to change the interval on which SeAT will ping out reminders for operations:
Note that these settings are global to all events.
Closes #22
Closes #23