fixed: undefined method column_types #1
Conversation
| klass.column_types[attr].type | ||
| column = klass.columns_hash[attr] | ||
| return if column.nil? | ||
| column.type |
There was a problem hiding this comment.
Just nit-picking, but you could do this in two line 
:
column = klass.colums_hash[attr]
column.type unless column.nil?
# or
column&.type # too bad this can't be used :(
# or
column.try! :type
|
👍 on this. Left a troll comment, but other than that this is great. How do you feel about pointing this to the thoughtbot/administrate repo? I did take a lot of passion in making a Rails 5 supportable Administrate, but it was apparent that while I was modifying their test suite, the PRs took a lot of energy and annoyance to get merged. Are you also having this issue? Merging, however I'd love to hear your thoughts and problems with Rails 5 support :) |
|
Honestly, we might have to wait a while before Administrate can fully support Rails 5. This was actually my first time using Administrate, but still this bug was pretty easy to fix. However, once it was fixed, loading up a dashboard view in my app led to more crashes within ActiveSupport of all things, triggered by Administrates templates. I did some research, and tried a few things but quickly landed myself in dependency hell. So, in the end I was unable to use Administrate for my project. From that experience, it seems like the gems that Administrate depends on haven't been updated yet either. Like everyone's holding their breath for Rails 5 release candidate. Specifically, Kaminari seemed to be broken in untenable ways and its 1.0 release is still in alpha. Once I hit the Kaminari bug, I gave up. Regarding PRs, I haven't attempted to get any merged, so I can't speak to that. |
|
@mklbtz thanks for the response :). Was great to read through. |
Using this gem with
rails 5.0.0.beta4, I received the error:undefined method ' column_types'when running theadministrate:installtask. The error originated fromDashboardGenerator#column_type_for_attribute. The receiver of the call tocolumn_typeswas an instance ofConnectionAdapters::Column, which has apparently never implemented that method.Anyway, I replaced it with a call to
columns_hash. I also return nil if no column matching the attribute exists. This is needed to support relationship attributes.