-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanilla Item Extension #302
base: master
Are you sure you want to change the base?
Conversation
Added Echo Shards and Amethyst Crystals to item id map.
Add Echo Shard & Amethyst Crystal Item IDs.
Added Echo Shards & Amethyst Crystals to registered ids.
Removed getName()
Remove getName()
Changed amethyst_crystal to amethyst_shard to correct error.
Change ID
AMETHYST_CRYSTAL -> AMETHYST_SHARD
# Details: - 18 Armor Trim Templates (items) - 15 Other Vanilla Items
Registered new vanilla items.
Forgot SnifferEgg lol...
Fix invalid ID.
Fixed missing comma
Reverted to original
I think there is a lack of implementation. |
Alright, what do you suggest adding then? |
1.21.50 - Added Resin Clump & Resin Brick items.
No extra functionality needed.
No extra functionality needed.
No extra functionality needed.
No extra functionality needed.
Changed comment, the brushing animation already occurs.
Added the default bundle (in the last commit.) This commit has added all the color varients.
Added missing use statements. (pocketmine\item\Item & ItemFactory)
Iron Ore now drops raw iron.
Fixed typo that remained unnoticed for 4 years.
Attempt at making raw ores smeltable.
This should be stable enough to merge now. TO-DO:
Changes
|
Implemented 123 new block ids! (Use extended blocks to register and use)
Vanilla Block ID Extension:Added 123 new blocks to block_id_map, once implemented, they should be usable via ExtendedBlocks. TO-DO:
|
Added previously implemented IDs that weren't here from item_id_map.json.
Remove unnecessary comment
Registered previously added items. (936-954)
New Items RegisteredRegistered block ids from 937-954.
|
src/pocketmine/item/ItemFactory.php
Outdated
|
||
// Register newer items. | ||
self::registerItem(new Item(Item::ECHO_SHARD, 0, "Echo Shard")); | ||
//self::registerItem(new Item(Item::AMETHYST_CRYSTAL, 0, "Amethyst Crystal")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no AMETHYST_CRYSTAL constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
therefore, i commented it out (see my last commit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed the issue. It was supposed to be AMETHYST_SHARD.
src/pocketmine/item/RawCopper.php
Outdated
use pocketmine\block\Block; | ||
use pocketmine\Player; | ||
|
||
class RawCopper extends Item { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no point of this class
src/pocketmine/item/RawGold.php
Outdated
use pocketmine\block\Block; | ||
use pocketmine\Player; | ||
|
||
class RawGold extends Item { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as for RawCopper
src/pocketmine/item/RawIron.php
Outdated
use pocketmine\block\Block; | ||
use pocketmine\Player; | ||
|
||
class RawIron extends Item { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as for RawCopper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to remove them because I was trying to make them smeltable which wasn't possible through those classes.
Fixed typo for Amethyst Crystals/Shards. The wrong constant was used. (AMETHYST_CRYSTAL -> AMETHYST_SHARD)
Fixes
|
35 New Items