Fix connection leak (goss-org#221)

BenjaminHerbert · May 28, 2020 · 30c5267 · 30c5267
1 parent fde81f0
commit 30c5267
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/resource/validate.go b/resource/validate.go
@@ -297,6 +297,14 @@ func ValidateContains(res ResourceRead, property string, expectedValues []string
 			Duration:     time.Now().Sub(startTime),
 		}
 	}
+
+	defer func() {
+		//Do we need to close the stream?
+		if rc, ok := fh.(io.ReadCloser); ok {
+			rc.Close()
+		}
+	}()
+
 	scanner := bufio.NewScanner(fh)
 	var found []patternMatcher
 	for scanner.Scan() {

diff --git a/system/http.go b/system/http.go
@@ -45,6 +45,7 @@ func (u *DefHTTP) setup() error {
 
 	tr := &http.Transport{
 		TLSClientConfig: &tls.Config{InsecureSkipVerify: u.allowInsecure},
+		DisableKeepAlives: true,
 	}
 	client := &http.Client{
 		Transport: tr,