Fix bug where package name instead of description is written into des…

…cription property
BenjaminRi · Feb 12, 2023 · 0cd17d6 · 0cd17d6
1 parent 08e3d56
commit 0cd17d6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "winresource"
 description = "Create and set windows icons and metadata for executables"
-version = "0.1.13"
+version = "0.1.14"
 authors = ["Max Resch <resch.max@gmail.com>"]
 license = "MIT"
 repository = "https://github.com/BenjaminRi/winresource"

diff --git a/lib.rs b/lib.rs
@@ -161,10 +161,19 @@ impl WindowsResource {
             "ProductName".to_string(),
             env::var("CARGO_PKG_NAME").unwrap(),
         );
-        props.insert(
-            "FileDescription".to_string(),
-            env::var("CARGO_PKG_NAME").unwrap(),
-        );
+
+        // If there is no description, fallback to name
+        let description = if let Ok(description) = env::var("CARGO_PKG_DESCRIPTION") {
+            if !description.is_empty() {
+                description
+            } else {
+                env::var("CARGO_PKG_NAME").unwrap()
+            }
+        } else {
+            env::var("CARGO_PKG_NAME").unwrap()
+        };
+
+        props.insert("FileDescription".to_string(), description);
 
         parse_cargo_toml(&mut props).unwrap();