Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigNumber Issue - new BigNumber() number type has more than 15 significant digits #383

Closed
j0nxs opened this issue Oct 3, 2018 · 4 comments
Closed

BigNumber Issue - new BigNumber() number type has more than 15 significant digits #383

j0nxs opened this issue Oct 3, 2018 · 4 comments

Comments

@j0nxs
Copy link

j0nxs commented Oct 3, 2018

Hello,

thx for this great library, but i have one thing which is very importent for me.
Please support bigger numbers or a configurable option to set the BigNumber Object to no error reporting.
In the following link can you see my problem. I have no option to change your BigNumber Object from external.

MikeMcl/bignumber.js#14
@sergey-shablenko
Copy link

Any news here? Issue still there, how to prevent crash?

BenjaminVanRyseghem added a commit that referenced this issue May 30, 2020
@BenjaminVanRyseghem
Expose BigNumber used in numbro
c0eae82 
Fix #383
Allow users to configure BigNumber by exposing it as `numbro.BigNumber`.
@BenjaminVanRyseghem
Copy link
Owner

@all-contributors please add j0nxs for bug

@allcontributors allcontributors bot mentioned this issue May 30, 2020
Merged
@allcontributors
Copy link
Contributor

@BenjaminVanRyseghem

I've put up a pull request to add @j0nxs! 🎉

@BenjaminVanRyseghem
Copy link
Owner

in numbro 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BenjaminVanRyseghem @j0nxs @sergey-shablenko