Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small negative numbers get the leading zero incorrectly cut off #392

Closed
cnrudd opened this issue Oct 26, 2018 · 2 comments · Fixed by #393
Closed

Small negative numbers get the leading zero incorrectly cut off #392

cnrudd opened this issue Oct 26, 2018 · 2 comments · Fixed by #393

Comments

@cnrudd
Copy link
Contributor

cnrudd commented Oct 26, 2018

Small negative numbers get the leading zero incorrectly cut off when rounded and thousandSeparated.

See demo of bug:
https://numbrojs.com/try-me.html?lang=en-US&value=-0.00490&format=%7B%22mantissa%22%3A2%2C%22trimMantissa%22%3Afalse%2C%22thousandSeparated%22%3Atrue%7D
@cnrudd cnrudd mentioned this issue Oct 26, 2018
Merged
BenjaminVanRyseghem pushed a commit that referenced this issue Apr 4, 2019
@cnrudd @BenjaminVanRyseghem
Fix #392 (#393)
ddd1b15
@BenjaminVanRyseghem
Copy link
Owner

in numbro 2.2.0

@cnrudd
Copy link
Contributor Author

cnrudd commented Mar 18, 2020

Merci!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for #392: Small negative numbers get the leading zero incorrectly cut off
2 participants
@BenjaminVanRyseghem @cnrudd