-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jshint improvements #26
Merged
BenjaminVanRyseghem
merged 5 commits into
BenjaminVanRyseghem:develop
from
Graham42:tighten-jshint
Apr 25, 2015
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e8ba476
Add strict .jshintrc and correct subsequent errors
baer 3019498
Revert Math.floor changes...
Graham42 ffdc325
Revise jshintrc. Allow bitwise ops, enable node env...
Graham42 08498b6
Correct jshint errors
Graham42 cbbfce5
Set debug env to false for jshint, update jshintignore
Graham42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
node_modules/ | ||
dist/ | ||
*.min.* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
{ | ||
|
||
// == Enforcing Options =============================================== | ||
// | ||
// These options tell JSHint to be more strict towards your code. | ||
|
||
"bitwise" : false, // Prohibit bitwise operators (&, |, ^, etc.). | ||
"camelcase" : true, // Force all variable names to use either camelCase style or UPPER_CASE with underscores. | ||
"curly" : true, // Require {} for every new block or scope. | ||
"eqeqeq" : true, // Require triple equals i.e. `===`. | ||
"es3" : false, // Adhere to ECMAScript 3 specification for legacy browsers like Internet Explorer 6/7/8. | ||
"forin" : true, // Tolerate `for in` loops without `hasOwnPrototype`. | ||
"immed" : true, // Require immediate invocations to be wrapped in parens e.g. `( function(){}() );` | ||
"indent" : 4, // Specify indentation spacing | ||
"latedef" : true, // Prohibit variable use before definition. | ||
"newcap" : true, // Require capitalization of all constructor functions e.g. `new F()`. | ||
"noarg" : true, // Prohibit use of `arguments.caller` and `arguments.callee`. | ||
"noempty" : true, // Prohibit use of empty blocks. | ||
"nonew" : true, // Prohibit use of constructors for side-effects. | ||
"plusplus" : false, // Prohibit use of `++` & `--`. | ||
"quotmark" : "single", // Forces single quotes for strings | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
"undef" : true, // Require all non-global variables be declared before they are used. | ||
"unused" : true, // Prevent declaring unused functions and variables. | ||
"strict" : true, // Require `use strict` pragma in every file. | ||
"maxparams" : 4, // Set the max number of formal parameters allowed per function | ||
"maxlen" : 120, // Set the maximum line length | ||
|
||
// == Relaxing Options ================================================ | ||
// | ||
// These options allow you to suppress certain types of warnings. Use | ||
// them only if you are absolutely positive that you know what you are | ||
// doing. | ||
|
||
"asi" : false, // Tolerate Automatic Semicolon Insertion (no semicolons). | ||
"boss" : false, // Tolerate assignments inside if, for & while. Usually conditions & loops are for comparison, not assignments. | ||
"debug" : false, // Allow debugger statements e.g. browser breakpoints. | ||
"eqnull" : false, // Tolerate use of `== null`. | ||
"esnext" : false, // Allow ES.next specific features such as `const` and `let`. | ||
"evil" : false, // Tolerate use of `eval`. | ||
"expr" : false, // Tolerate `ExpressionStatement` as Programs. | ||
"funcscope" : false, // Tolerate declarations of variables inside of control structures while accessing them later from the outside. | ||
"globalstrict" : false, // Allow global "use strict" (also enables 'strict'). | ||
"iterator" : false, // Allow usage of __iterator__ property. | ||
"lastsemic" : false, // Tolerat missing semicolons when the it is omitted for the last statement in a one-line block. | ||
"laxbreak" : false, // Tolerate unsafe line breaks e.g. `return [\n] x` without semicolons. | ||
"laxcomma" : false, // Suppress warnings about comma-first coding style. | ||
"loopfunc" : false, // Allow functions to be defined within loops. | ||
"moz" : false, // Use Mozilla JavaScript extensions. Unless you develop specifically for the Firefox web browser you don't need this option. | ||
"multistr" : false, // Tolerate multi-line strings. | ||
"proto" : false, // Tolerate __proto__ property. This property is deprecated. | ||
"scripturl" : false, // Tolerate script-targeted URLs. | ||
"shadow" : false, // Allows re-define variables later in code e.g. `var x=1; x=2;`. | ||
"sub" : false, // Tolerate all forms of subscript notation besides dot notation e.g. `dict['key']` instead of `dict.key`. | ||
"supernew" : false, // Tolerate `new function () { ... };` and `new Object;`. | ||
"validthis" : false, // Tolerate strict violations when the code is running in strict mode and you use this in a non-constructor function. | ||
|
||
// == Environments ==================================================== | ||
// | ||
// These options pre-define global variables that are exposed by | ||
// popular JavaScript libraries and runtime environments—such as | ||
// browser or node.js. | ||
|
||
"browser" : true, // Standard browser globals e.g. `window`, `document`. | ||
"couch" : false, // Enable globals exposed by CouchDB. | ||
"devel" : false, // Allow development statements e.g. `console.log();`. | ||
"jquery" : false, // Enable globals exposed by jQuery JavaScript library. | ||
"node" : true, // Enable globals available when code is running inside of the NodeJS runtime environment. | ||
"nonstandard" : false, // Define non-standard but widely adopted globals such as escape and unescape. | ||
"wsh" : false, // Enable globals available when your code is running as a script for the Windows Script Host. | ||
|
||
// == Global Variables ================================================ | ||
// | ||
// These will be ignored by jsHint and will not throw warning caused by the | ||
// debug or undef options | ||
|
||
"globals": { | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should be
false
andforEach
should be used insteadThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meaning of this is not which loop to use, but rather to enforce checking inside a
for..in
loop which is meant to make you checkhasOwnProperty
on keys of an object.Also,
forEach
is actually not as fast as a regular for loop http://jsperf.com/for-vs-foreach/313.