-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #399
Update dependencies #399
Conversation
@@ -0,0 +1,3 @@ | |||
module.exports = { | |||
presets: ["@babel/preset-env"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be transparent. Babel's docs specify that:
"By default, it has the same behavior as previous presets to compile ES2015+ to ES5"
https://babeljs.io/docs/en/env
The great thing about this plugin (if you haven't used it yet) is that you can add config to specify a support matrix and only the applicable presets will be applied. For example, if you only want to support down to IE9 and Node LTS you could easily do that.
"gulp-util": "^3.0.8", | ||
"istanbul": "^0.4.5", | ||
"jasmine": "^3.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two were included as transitive deps but without a top level include they are not available in the node_modules/.bin
directory which means that the npm run coverage
script wasn't working.
Thank you 😄 |
in numbro 2.1.2 |
Problem
Out of date dependencies were causing the following issues:
npm install
on Node 10es2015
babel preset is no longer getting fixes for compatFix
npm run lint
to thepackage.json
- it was missingjasmine
andistanbul
dependencies to makenpm run coverage
work properly