Update abbreviations in german language file #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome!!! Thanks a lot 😄 |
|
let's wait for the CI now 😄 |
|
Oh wow! I only went to grab a coffee and wondered where my PR went... This must be the fastest merge I have seen so far 😁 |
|
in numbro 2.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the German language file uses the English abbreviations for "million" and so on. This is particularly unhelpful because the names for large numbers do not match at all:
This exposes a bug in the unformatter's handling of byte-formatted numbers. In a string like
1Bi(for one billion), the byte unformatter finds the capital B in the string and therefore treats this as bytes, which obviously isn't intended. I fixed this by making the unformatter search for complete postfixes without additional characters.