-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When eslint-plugin-html
is extended, rules from other plugins don't work.
#176
Comments
You should not use both |
Why can't I use both of them? Thank you for your response! |
Ah! I thought I see what's going on: my plugin takes precedence and keeps only the JavaScript from HTML files. Since you don't have any in your minimal example, the I have a POC to fix this issue, but still need some work. |
Fixed in v7.1.0! Thank you for your patience. Let me know how it works for you. |
eslint-plugin-html disables the rest of the rules applied to html files. this issue has been fixed in: BenoitZugmeyer/eslint-plugin-html#176
eslint-plugin-html disables the rest of the rules applied to html files. this issue has been fixed in: BenoitZugmeyer/eslint-plugin-html#176
eslint-plugin-html disables the rest of the rules applied to html files. this issue has been fixed in: BenoitZugmeyer/eslint-plugin-html#176 fixup! fix(eslint-config-enterprise): update eslint-plugin-html Revert "fix(eslint-config-enterprise): update eslint-plugin-html" This reverts commit d7b0343. Revert "fixup! fix(eslint-config-enterprise): update eslint-plugin-html" This reverts commit 0ad1ca1.
Description
When
eslint-plugin-html
is extended, rules from other plugins don't work.Initially, I ran into a problem in an angular project where the sharable config (it used this plugin) was breaking the extended recommended rules. So I started to find out, simplifying the code, removing deps, and came to the most simple reproduction with a single config file.
There are README files:
Minimum reproduction: https://github.com/ddubrava/eslint-plugin-html-repro
Angular project reproduction: https://github.com/ddubrava/eslint-config-tinkoff-html-issue
Setup configuration
The text was updated successfully, but these errors were encountered: