Add "Icon" Section to Phase Config. #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will comment that it looks ugly to set icon type as base64 string ... But it is just my thoughts. |
tastybento
requested changes
Jul 6, 2021
src/main/java/world/bentobox/aoneblock/oneblocks/OneBlocksManager.java
Outdated
Show resolved
Hide resolved
src/main/java/world/bentobox/aoneblock/oneblocks/OneBlocksManager.java
Outdated
Show resolved
Hide resolved
tastybento
approved these changes
Jul 6, 2021
tastybento
added a commit
that referenced
this pull request
Aug 19, 2021
* Add "Icon" Section to Phase Config. (#178) * Add "Icon" Section to Phase Config. * Fix Code Smells/Inconsistencies * Added badges * Remove NPE potential bugs * Fixes incorrect commands and permissions (#128) Update to the AOneBlock command and permission set instead of using AcidIsland and BSkyBlock. Co-authored-by: tastybento <tastybento@users.noreply.github.com> * Update Vietnamese (#143) * Expose BentoBox 1.14 onRespawnCommands. (#158) BentoBoxWorld/BentoBox#1719 * Expose BentoBox 1.16 portal generation mechanics. (#159) BentoBoxWorld/BentoBox#1718 * Remove handlers from events (fixes #161) (#162) * Revert "Remove handlers from events (fixes #161) (#162)" (#180) This reverts commit 4615d58. * Version 1.8.1 * Add Hologram Support to AOneBlock Phases (#179) * Add Holograms to AOneBlock Phases * Add Holograms to AOneBlock Phases * Fix Holograms Not Loading/Add Default Holograms & Fix Hologram Persistence * Fix Merge of Develop, Github's Web Interface is Bad * Convert to Addon#AllLoaded for Hologram Loading * Update 0_plains.yml (#181) * German translation (#184) * Translate de.yml via GitLocalize * Update de.yml Co-authored-by: tastybento <tastybento@wasteofplastic.com> Co-authored-by: tastybento <tastybento@users.noreply.github.com> * Prevent NPE's * Fix sonarcloud complaints about potential NPE * Remove sonar profile * Convert to record * Use Optional isEmpty * Update vi.yml (#186) * Fixed bug if HolographicDisplays is not present. The #179 PR causes the BlockListener to not register if HolographicDisplays is not present. #189 This puts all the HolographicDisplays code in its own class that only gets called if HolographicDisplays exists. It also removes the static getInstance method. * Drop chest items when chest is broken. If drop on top setting is true, then only the chest was being dropped and not the contents of the chest. Also applies to other inventory holders. #191 Co-authored-by: Fredthedoggy <45927799+Fredthedoggy@users.noreply.github.com> Co-authored-by: BONNe <bonne@bonne.id.lv> Co-authored-by: Huynh Tien <huynhqtienvtag@gmail.com> Co-authored-by: Rick Strafy <45132928+Rixafy@users.noreply.github.com> Co-authored-by: gitlocalize-app[bot] <55277160+gitlocalize-app[bot]@users.noreply.github.com>
tastybento
added a commit
that referenced
this pull request
Nov 26, 2021
* Add "Icon" Section to Phase Config. (#178) * Add "Icon" Section to Phase Config. * Fix Code Smells/Inconsistencies * Added badges * Remove NPE potential bugs * Fixes incorrect commands and permissions (#128) Update to the AOneBlock command and permission set instead of using AcidIsland and BSkyBlock. Co-authored-by: tastybento <tastybento@users.noreply.github.com> * Update Vietnamese (#143) * Expose BentoBox 1.14 onRespawnCommands. (#158) BentoBoxWorld/BentoBox#1719 * Expose BentoBox 1.16 portal generation mechanics. (#159) BentoBoxWorld/BentoBox#1718 * Remove handlers from events (fixes #161) (#162) * Revert "Remove handlers from events (fixes #161) (#162)" (#180) This reverts commit 4615d58. * Version 1.8.1 * Add Hologram Support to AOneBlock Phases (#179) * Add Holograms to AOneBlock Phases * Add Holograms to AOneBlock Phases * Fix Holograms Not Loading/Add Default Holograms & Fix Hologram Persistence * Fix Merge of Develop, Github's Web Interface is Bad * Convert to Addon#AllLoaded for Hologram Loading * Update 0_plains.yml (#181) * German translation (#184) * Translate de.yml via GitLocalize * Update de.yml Co-authored-by: tastybento <tastybento@wasteofplastic.com> Co-authored-by: tastybento <tastybento@users.noreply.github.com> * Prevent NPE's * Fix sonarcloud complaints about potential NPE * Remove sonar profile * Convert to record * Use Optional isEmpty * Update vi.yml (#186) * Fixed bug if HolographicDisplays is not present. The #179 PR causes the BlockListener to not register if HolographicDisplays is not present. #189 This puts all the HolographicDisplays code in its own class that only gets called if HolographicDisplays exists. It also removes the static getInstance method. * Drop chest items when chest is broken. If drop on top setting is true, then only the chest was being dropped and not the contents of the chest. Also applies to other inventory holders. #191 * Version 1.9.0 * Make AOneBlock a Pladdon. * Prevent liquid flow into magic block. #193 * Adds BlockClearEvent to API This enables plugins like AdvancedChests to know that a block will be cleared as a result of an entity spawning and handle the situation. * Fix for phases with spaces in the name. #196 * Fix issue with hologram NPE. * Re-engineer for 1.16.5 support. * Update es.yml (#201) * fix nullable nextKey on OneBlocksManager (#197) * Fix references to "/bsbadmin" in config (#194) * Fix references to "/bsbadmin" in config The configuration file's comments contain multiple references to the "/bsbadmin" command. This changes them to "/obadmin", the correct command for AOneBlock. * Fix command references in resources/config.yml * Use string escaping to preserve unicode chars May help #204 * Escape unicode chars. * Fix code smells. * BentoBox 1.18 API * Adjust API versions to allow 1.16.5 usage. #196 * Update zh-CN.yml (#205) * Enable customization of the scale character #207 * Fixes missing entries to phase files when adding chest #210 * Prevent null call to User.getInstance * Do not reset inventory, health, and food by default. This is so newbie admins don't complain when they start a new game and their inventory is wiped. Use InvSwitcher. * Add setcount command for player. (#211) * Add setcount command for player. #206 * Fix bug where target name wasn't used for island * Made command in-game only. Co-authored-by: Fredthedoggy <45927799+Fredthedoggy@users.noreply.github.com> Co-authored-by: BONNe <bonne@bonne.id.lv> Co-authored-by: Huynh Tien <huynhqtienvtag@gmail.com> Co-authored-by: Rick Strafy <45132928+Rixafy@users.noreply.github.com> Co-authored-by: gitlocalize-app[bot] <55277160+gitlocalize-app[bot]@users.noreply.github.com> Co-authored-by: KrazyxWolf <68208993+KrazyxWolf@users.noreply.github.com> Co-authored-by: James Tai <45131430+j-tai@users.noreply.github.com> Co-authored-by: Katorly <70022443+katorly@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds an (optional) "Icon" section to phase files, that allows you to either set a valid MC material (Not used in the phase at all) or add a Base64 Head icon.