Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Generators #67

Merged
merged 16 commits into from
Dec 14, 2021
Merged

Optional Generators #67

merged 16 commits into from
Dec 14, 2021

Conversation

HSGamer
Copy link
Contributor

@HSGamer HSGamer commented Nov 9, 2021

Changes

  • Back to the old block generators so that we can keep the current settings
  • Move the new block populator to be an BlockPopulator, and an option in the settings
  • Possibly fix CME when generating new worlds #66 as I think we can't set the block type twice at the same location
  • An hasAI option for ENTITY, so the format will be ENTITY:<type>:<percent>:<amount>[:<hasAI>]

Notice

  • The new block generator is not customizable. Will you do it in the future?

@HSGamer
Copy link
Contributor Author

HSGamer commented Nov 18, 2021

Any suggestion?

@tastybento tastybento mentioned this pull request Nov 22, 2021
@tastybento
Copy link
Member

Thanks for the PR! I was working on a 1.17 generator too. Unfortunately due to IRL work I don't have time to work on it much so I just made #68 . Please tell me what you think.

@HSGamer
Copy link
Contributor Author

HSGamer commented Nov 22, 2021

Thanks for the PR! I was working on a 1.17 generator too. Unfortunately due to IRL work I don't have time to work on it much so I just made #68 . Please tell me what you think.

My PR moved your ore generator to an BlockPopulator, so that we could give the user to choose the old settings or the new world generator.
If you changed anything in your new PR #68, from my perspective, you should merge this PR and then apply your changes to the new BlockPopulator named NewMaterialPopolator.

@BONNe
Copy link
Member

BONNe commented Nov 22, 2021

I am confused a bit.
What is the difference between both PRs?

@HSGamer
Copy link
Contributor Author

HSGamer commented Nov 23, 2021

As I saw, you just re-opened the old PR #61.
Did you change anything new?

@HSGamer
Copy link
Contributor Author

HSGamer commented Nov 26, 2021

All populators are updated to the new API. It's good to merge now.

@tastybento tastybento merged commit 7824c7b into BentoBoxWorld:develop Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CME when generating new worlds
3 participants