Skip to content

Commit

Permalink
lib: event static properties non writable and configurable
Browse files Browse the repository at this point in the history
The idl definition for Event makes the properties constant
this means that they shouldn't be configurable and writable.
However, they were, and this commit fixes that.

Fixes: nodejs#50417
  • Loading branch information
BenzeneAlcohol committed Nov 1, 2023
1 parent 88a46fd commit ddf17fb
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions test/parallel/test-event-target.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,8 @@ const eventPhases = {

// Using Object.keys to get the properties from the Event object
const eventKeys = Object.keys(Event);
console.log(eventKeys);

for (const [prop, value] of Object.entries(eventPhases)) {
console.log(prop);
console.log(value);
// Check if the property exists in the Event object
assert.ok(eventKeys.includes(prop), `Event does not have the property: ${prop}`);

Expand Down

0 comments on commit ddf17fb

Please sign in to comment.