Improve test coverage

BepInEx · Feb 8, 2024 · 5d29435 · 5d29435
1 parent dfd65c3
commit 5d29435
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/HarmonyTests/Patching/Assets/Specials.cs b/HarmonyTests/Patching/Assets/Specials.cs
@@ -147,20 +147,26 @@ public class OptionalPatch
 		[HarmonyPostfix, HarmonyOptional, HarmonyPatch(typeof(OptionalPatch), nameof(NotEnumerator), MethodType.Async)]
 		public static void Test5() => throw new InvalidOperationException();
 
-		[HarmonyPostfix]
+		[HarmonyPrefix]
 		[HarmonyOptional]
 		[HarmonyPatch(typeof(OptionalPatch), "missing_method1")]
-		[HarmonyPatch(typeof(OptionalPatch), nameof(NotEnumerator), MethodType.Normal)]
+		[HarmonyPatch(typeof(OptionalPatch), nameof(Thrower), MethodType.Normal)]
 		[HarmonyPatch(typeof(OptionalPatch), "missing_method2")]
-		public static void Test6() => throw new InvalidOperationException();
+		public static bool Test6() => false;
 
 		private void NotEnumerator() => throw new InvalidOperationException();
+		public static void Thrower() => throw new InvalidOperationException();
 	}
 
 	public static class OptionalPatchNone
 	{
-		[HarmonyPrefix, HarmonyPatch(typeof(OptionalPatch), "missing_method")]
-		public static void Prefix() => throw new InvalidOperationException();
+		[HarmonyPrefix]
+		[HarmonyPatch(typeof(OptionalPatch), "missing_method1")]
+		[HarmonyPatch(typeof(OptionalPatch), nameof(Thrower), MethodType.Normal)]
+		[HarmonyPatch(typeof(OptionalPatch), "missing_method2")]
+		public static bool Test6() => false;
+
+		public static void Thrower() => throw new InvalidOperationException();
 	}
 
 	public static class SafeWrapPatch

diff --git a/HarmonyTests/Patching/Specials.cs b/HarmonyTests/Patching/Specials.cs
@@ -48,9 +48,13 @@ public void Test_Optional_Patch()
 			var instance = new Harmony("special-case-optional-patch");
 			Assert.NotNull(instance);
 
+			Assert.Throws<InvalidOperationException>(OptionalPatch.Thrower);
 			Assert.DoesNotThrow(() => instance.PatchAll(typeof(OptionalPatch)));
+			Assert.DoesNotThrow(OptionalPatch.Thrower);
 
+			Assert.Throws<InvalidOperationException>(OptionalPatchNone.Thrower);
 			Assert.Throws<HarmonyException>(() => instance.PatchAll(typeof(OptionalPatchNone)));
+			Assert.Throws<InvalidOperationException>(OptionalPatchNone.Thrower);
 		}
 
 		[Test]