Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensors #195

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Sensors #195

wants to merge 5 commits into from

Conversation

theilem
Copy link
Collaborator

@theilem theilem commented Oct 11, 2023

Sensors implementation with a Carla example

@dfremont
Copy link
Collaborator

Hi Mirco, the CI is failing since we now enforce certain formatting requirements. See here for how to get the formatters to run automatically when you commit; for a one-time fix for the files you've already committed, you can run make format in the root directory of the repo.

Speaking of CI, it would be great if you could add some tests for the new functionality to the test suite (maybe in tests/syntax/test_dynamics.py, next to the test for the record statement). We can't test the CARLA implementation right now, but your test could implement a dummy sensor (e.g. one that returns the ground-truth position) just so we can check that the overall flow works correctly.

@Eric-Vin Eric-Vin mentioned this pull request Nov 29, 2023
@dfremont dfremont self-assigned this May 9, 2024
@dfremont dfremont added this to the 3.1.0 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants