Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apple Silicon devices can generate multiple scenarios #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abanuelo
Copy link
Collaborator

Description

For this fix, I noticed that when if we use pyglet>=1.5.28 in our pyproject.toml it will use default to shutting down the generated Scenario immediately after the .show() is called to render the trimesh Scene. To resolve this I played with installing earlier versions of pyglet and landed on 1.5.26 as a good alternative to allow us to create multiple scenarios on Apple silicon devices, as is the expected behavior. Below is a video illustrating the fix:

fixed-230.mov

Issue Link

#230

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from dfremont and Eric-Vin April 25, 2024 19:47
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (747f211) to head (030c288).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   86.15%   86.11%   -0.05%     
==========================================
  Files         144      144              
  Lines       24949    24984      +35     
==========================================
+ Hits        21494    21514      +20     
- Misses       3455     3470      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eric-Vin
Copy link
Collaborator

Hmm, I'm hesitant to pin a specific version since we might block downstream users who are using Scenic as a library. Is this a bug fix where we can set a floor instead?

@abanuelo
Copy link
Collaborator Author

@dfremont and I discussed the proposed fix in this PR and he suggested we make the cieling for pyglet 1.5.26 but if trimesh does upgrade its library to support >2.0 pyglet we can adjust accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants