fix: Apple Silicon devices can generate multiple scenarios #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For this fix, I noticed that when if we use
pyglet>=1.5.28
in ourpyproject.toml
it will use default to shutting down the generated Scenario immediately after the.show()
is called to render the trimesh Scene. To resolve this I played with installing earlier versions ofpyglet
and landed on1.5.26
as a good alternative to allow us to create multiple scenarios on Apple silicon devices, as is the expected behavior. Below is a video illustrating the fix:fixed-230.mov
Issue Link
#230
Checklist
pytest
and/or other meansAdditional Notes