Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding flag for pyglet downgrade for Apple Silicon Devices #267

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abanuelo
Copy link
Collaborator

Description

As a temporarily workaround in place, we are working to add some steps in the documentation FAQs to get Apple Silicon users of Scenic to downgrade to pyglet 1.5.26 to be able to generate multiple scenes.

Issue Link

#230

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from dfremont and Eric-Vin May 16, 2024 20:45
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (6f37d6c) to head (c0c0d95).
Report is 25 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   91.17%   91.31%   +0.13%     
==========================================
  Files          54       54              
  Lines       13491    13550      +59     
==========================================
+ Hits        12301    12373      +72     
+ Misses       1190     1177      -13     

see 13 files with indirect coverage changes

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not totally clear, but I think you're suggesting people edit pyproject.toml? I'm not sure that's a great idea since it's somewhat error-prone and changes their local version relative to what's in the repo. What about just telling them to go through the usual installation (including activating a virtual environment) and then run pip install pyglet==1.5.26? Then checking the version of pyglet shouldn't be necessary, but if you want to add that I'd suggest pip show pyglet since it will print a lot less unrelated information.

-Revised pyglet installation instructions for Apple silicon based on review feedback.
-Suggested running pip install pyglet==1.5.26 in the virtual environment instead of editing pyproject.toml.
-Removed the pip freeze check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants