Migrate to esm #24
Closed
Migrate to esm #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this diff I convert source to esm so we can easily use this lib with native browser modules. This also allow bundlers do not add additional runtime to work around cjs. I converted warning.js to esm and built warning.cjs.js with rollup.
|
Do you have thoughts on this @BerkeleyTrue ? |
|
Thanks @TrySound. I've gave it some thought and IMHO this strays too far from the purpose of this library, to provide a mirror of fbjs/warning. At the moment, fbjs does not provide an ESM module. Until they do I won't be providing one here. Feel free to open an issue on the fbjs library to see if they would be receptive to this change. Happy Coding |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this diff I convert source to esm so we can easily use this lib with
native browser modules. This also allow bundlers do not add additional
runtime to work around cjs.
I converted warning.js to esm and built warning.cjs.js with rollup.