Login / Registration #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoom1337
reviewed
Sep 26, 2021
Comment on lines
19
to
20
| function Copyright(props: any) { | ||
| return ( |
There was a problem hiding this comment.
UPD: торопимся сдать, поэтому заменил сам)
Получится оперативно заменить Copyright на компонент Footer? Он в sprint_01 уже есть, внутри Footer та же самая разметка, просто он у нас уже создан и будет один на весь проект.
shoom1337
reviewed
Sep 26, 2021
| avatar: string; | ||
| } | ||
|
|
||
| export type SigninProps = Pick<User, "login"> & { password: string }; |
There was a problem hiding this comment.
Супер определение типа! Я бы создал два разных с дублированием login, password, а теперь отмечу себе и ещё раз прочитаю про утилиты и буду применять чаще
Alkamenos
previously approved these changes
Sep 26, 2021
| const history = createBrowserHistory(); | ||
| const StubComponent = () => <div>Under construction! 👻</div>; | ||
|
|
||
| const darkTheme = createTheme({ |
| import { Game } from "./pages/Game"; | ||
|
|
||
| declare module "@material-ui/core/styles" { |
There was a problem hiding this comment.
Это зачем? Я не придираюсь мне действительно интересно 🤔
| validationSchema: signInSchema, | ||
| onSubmit: (values) => { | ||
| signin(values).then((data) => { | ||
| history.push("/profile"); |
There was a problem hiding this comment.
Наверное сразу можно отправлять в /app
Alkamenos
approved these changes
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
базовая функциональность логина и регистрации.
красоту можно чуть попозже навести
+ нет обработок ошибок апи
closes #13