Финальное ревью #75
Merged
Финальное ревью #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
docker-compose.yaml в секции db перепутан DB_USER и DB_PASS |
|
Переменные DB_PASS и DB_PASSWORD (в db и app) приводят к путанице |
|
Доделать окончание игры |
|
Обратите внимание, что в .env файлах комментарии лучше оставлять на отдельной строке, иначе они воспринимаются как часть значения переменной |
|
Тема dark отсутствует в базе (запускал локально), при переключении возникает ошибка 500 |
|
Обновите тесты |
Signed-off-by: Leonid Artemev <alkamenos@gmail.com>
Signed-off-by: Leonid Artemev <alkamenos@gmail.com>
Signed-off-by: Leonid Artemev <alkamenos@gmail.com>
…end.mario into final-review
…end.mario into final-review
Signed-off-by: Leonid Artemev <alkamenos@gmail.com>
|
Исправил сломанные тесты |
Signed-off-by: Leonid Artemev <alkamenos@gmail.com>
Signed-off-by: Leonid Artemev <alkamenos@gmail.com>
Signed-off-by: Leonid Artemev <alkamenos@gmail.com>
Signed-off-by: Leonid Artemev <alkamenos@gmail.com>
Signed-off-by: Leonid Artemev <alkamenos@gmail.com>
ivan-infro
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.