Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions #339

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update versions #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a22c838
update versions
Bertk Dec 18, 2024
7fe00a1
fix version number
Bertk Dec 18, 2024
9eb8383
disaple intern feed
Bertk Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
</PropertyGroup>
<ItemGroup>
<GlobalPackageReference Include="SonarAnalyzer.CSharp" Version="10.3.0.106239" />
<GlobalPackageReference Include="SonarAnalyzer.CSharp" Version="10.4.0.108396" />
<GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.7.112" />
<GlobalPackageReference Include="System.CommandLine.Generator" Version="2.0.0-beta4.23307.1" />
</ItemGroup>
Expand Down Expand Up @@ -46,4 +46,4 @@
<PackageVersion Include="System.ServiceModel.Duplex" Version="6.0.0" />
<PackageVersion Include="System.Net.Http" Version="4.3.4" />
</ItemGroup>
</Project>
</Project>
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ Arcade-light is inspired from [dotnet/arcade](https://github.com/dotnet/arcade)
```json
{
"sdk": {
"version": "8.0.403",
"version": "8.0.404",
"rollForward": "latestFeature"
},
"tools": {
"dotnet": "8.0.403"
"dotnet": "8.0.404"
},
"msbuild-sdks": {
"DotNetDev.ArcadeLight.Sdk": "1.7.5"
"DotNetDev.ArcadeLight.Sdk": "1.8.0"
}
}
```
Expand Down Expand Up @@ -56,7 +56,7 @@ Arcade-light is inspired from [dotnet/arcade](https://github.com/dotnet/arcade)
</PropertyGroup>

<ItemGroup>
<GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.6.146" />
<GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.7.112" />
</ItemGroup>
...
<\Project>
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
<Project>
<PropertyGroup>
<!-- Libs -->
<XUnitVersion>2.9.2</XUnitVersion>
<XUnitV3Version>1.0.0</XUnitV3Version>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"dotnet": "9.0.100-rc.1.24452.12"
},
"msbuild-sdks": {
"DotNetDev.ArcadeLight.Sdk": "1.8.0-beta.1"
"DotNetDev.ArcadeLight.Sdk": "1.8.0"
}
}
6 changes: 3 additions & 3 deletions nuget.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<clear />
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
<add key="coverlet-nightly" value="https://pkgs.dev.azure.com/tonerdo/coverlet/_packaging/coverlet-nightly/nuget/v3/index.json" />
<add key="intern" value="https://pkgs.dev.azure.com/bertk0374/_packaging/intern/nuget/v3/index.json" />
<!--<add key="intern" value="https://pkgs.dev.azure.com/bertk0374/_packaging/intern/nuget/v3/index.json"--> />
<!--<add key="local-folder" value="C:\local_source" />-->
<add key="dotnet-libraries" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json" />
</packageSources>
Expand All @@ -18,8 +18,8 @@
<packageSource key="dotnet-libraries">
<package pattern="System.CommandLine*" />
</packageSource>
<packageSource key="intern">
<!--<packageSource key="intern">
<package pattern="DotNetDev.ArcadeLight*" />
</packageSource>
</packageSource>-->
</packageSourceMapping>
</configuration>
6 changes: 2 additions & 4 deletions src/RazorPages/RazorPagesTestSample.Tests/UnitTests/DataAccessLayerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
List<Message> result = await db.GetMessagesAsync();

// Assert
List<Message> actualMessages = Assert.IsAssignableFrom<List<Message>>(result);
List<Message> actualMessages = Assert.IsType<List<Message>>(result, exactMatch: false);
Assert.Equal(
expectedMessages.OrderBy(m => m.Id).Select(m => m.Text),
actualMessages.OrderBy(m => m.Id).Select(m => m.Text));
Expand All @@ -41,7 +41,7 @@
await db.AddMessageAsync(expectedMessage);

// Assert
Message actualMessage = await db.FindAsync<Message>(recId, TestContext.Current.CancellationToken);
Message actualMessage = await db.FindAsync<Message>(new object[] { recId, TestContext.Current.CancellationToken }, TestContext.Current.CancellationToken);
Assert.Equal(expectedMessage, actualMessage);
}

Expand Down Expand Up @@ -101,16 +101,14 @@
int recId = 4;

// Act
#pragma warning disable CA1031 // Do not catch general exception types
try
{
await db.DeleteMessageAsync(recId);
}
catch

Check warning on line 108 in src/RazorPages/RazorPagesTestSample.Tests/UnitTests/DataAccessLayerTest.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp) 

Modify 'DeleteMessageAsync_NoMessageIsDeleted_WhenMessageIsNotFound' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)

Check warning on line 108 in src/RazorPages/RazorPagesTestSample.Tests/UnitTests/DataAccessLayerTest.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp) 

Modify 'DeleteMessageAsync_NoMessageIsDeleted_WhenMessageIsNotFound' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)

Check warning on line 108 in src/RazorPages/RazorPagesTestSample.Tests/UnitTests/DataAccessLayerTest.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp) 

Modify 'DeleteMessageAsync_NoMessageIsDeleted_WhenMessageIsNotFound' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)

Check warning on line 108 in src/RazorPages/RazorPagesTestSample.Tests/UnitTests/DataAccessLayerTest.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp) 

Modify 'DeleteMessageAsync_NoMessageIsDeleted_WhenMessageIsNotFound' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
{
// recId doesn't exist
}
#pragma warning restore CA1031 // Do not catch general exception types

// Assert
List<Message> actualMessages = await db.Messages.AsNoTracking().ToListAsync(cancellationToken: TestContext.Current.CancellationToken);
Expand Down
Loading