Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper site type icons #327

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Conversation

Samuel-Therrien-Beslogic
Copy link
Contributor

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic commented Dec 10, 2024

  • The project passes automated tests locally (build, linting, etc.).
  • You updated the project's documentation with new changes.
  • You've linked any issue this PR closes
  • You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.

Make sure that the code wasn't copied from elsewhere (check one):

  • This is your own original code
  • You have made sure that we have permission to use the copied code and that we follow its licensing

Changes:

  • Removed all unused icons
  • Minified all svgs
  • Map pins are now generic, they can take any element, whether text or icons
  • Obsoleted canopeum_frontend/src/components/CustomIconBadge.tsx, IconBadge can now take a children
  • Created a SiteTypeIcon component dedicated to mapping the side id to its appropriate icon, whether its material or custom
    • Remove barely used material-icons package (our material icons are currently loaded through Google's CDN)

Closes #272

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic merged commit 1570205 into main Dec 10, 2024
6 checks passed
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic deleted the proper-site-type-icons branch December 10, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect site type icons for Canopeum and Farms Land
1 participant