Fixes SentateURL by creating a redirect page and function #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhik Do we need to redirect users? The original district URLs should be restored soon: nysenate/NYSenate.gov-Website-D9#41 |
|
The district URLs are working correctly now, without redirects: https://boundaries.beta.nyc/?map=ss senate-links.mov |
|
Great. I will undo the changes but keep the function to redirect for other district types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89 by creating an extra property
redirectUrlfor layers that does a lookup for the NYSenate url via the https://pubgeo.nysenate.gov/api/v2/map/senate endpoint.See docs for the endpoint here
The
redirectUrlis activated when /?redirect query parameter exist in the url.