Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
view shelter 2 (DEV-1079) #781
view shelter 2 (DEV-1079) #781
Changes from 2 commits
ec3f9c8
f99eda6
c81527a
ee190fd
32c9b01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the color
success-90
is only defined in the context ofshelter-web
. that's ok for today, but we may need add global tailwind config file in libs somwhere. for now maybe just leave a TODO comment?also, should
px-4 py-1
go withbaseClasses
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paddings no because if border comes the size will be different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaah ok.
if a different variant can have a border, then another way is to include border in baseClasses (with same color as background), and then just override the border-color. but not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just FYI:
twMerge
together withclsx
(like in mergeCss) can be really useful hereto allow
className
to override everyting:const pillClass = mergeCss(baseClasses, typeClasses[type], className);
to allow adding
className
, but never overridingbaseClasses
ortypeClasses[type]
:const pillClass = mergeCss(className, baseClasses, typeClasses[type]);