Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shelter filter names (DEV-1078) #797

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Fix shelter filter names (DEV-1078) #797

merged 2 commits into from
Dec 23, 2024

Conversation

mikefeldberg
Copy link
Contributor

@mikefeldberg mikefeldberg commented Dec 20, 2024

DEV-1078

Summary by Sourcery

Bug Fixes:

  • Correct the filter names for shelter types and room styles to match the backend API.

@mikefeldberg mikefeldberg self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request renames the shelterType and roomStyle filter names to shelterTypes and roomStyles respectively in the GraphQL schema and corresponding Python code. This change is made to better reflect that these filters accept multiple values.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Renamed shelterType and roomStyle filter names to shelterTypes and roomStyles
  • Renamed shelterType to shelterTypes in the GraphQL schema
  • Renamed roomStyle to roomStyles in the GraphQL schema
  • Renamed shelter_type to shelter_types in the Python code
  • Renamed room_style to room_styles in the Python code
apps/betterangels-backend/schema.graphql
apps/betterangels-backend/shelters/types.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mikefeldberg - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This change modifies field names in the API schema - please ensure this breaking change is properly documented and communicated to API consumers
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mikefeldberg mikefeldberg added the graphql-inspector:approved-breaking-change Auto approve breaking changes to graphql schema label Dec 20, 2024
@tglaz tglaz merged commit dc608f0 into main Dec 23, 2024
8 checks passed
@tglaz tglaz deleted the DEV-1078/fix-filter-names branch December 23, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql-inspector:approved-breaking-change Auto approve breaking changes to graphql schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants