-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerized integration test #25
Conversation
Thanks so much for the PR, and apologies for it taking so long to get to it. I absolutely love this idea, but I'd like to hold off for now. A couple of reasons:
|
Hey folks, FYI
We're very welcome new TestContainers users and ready to help and prioritize the issues if they are blockers for you :) |
I believe that things have progressed well enough with the TestContainers project that I'm comfortable pulling this in now, and doing away with the current manual integration tests setup. Unfortunately, this PR has picked up some merge conflicts since it was originally created. I'm not sure if you'd like to merge from |
It's been about a month, and this looks to be abandoned. Apologies for the length of time that I let it sit in limbo... I just really didn't want to pull the trigger on this until TestContainers support for Windows was in a decent place. At any rate, since this PR had grown chock full of merge conflicts, I ended up adding TestContainers support in #54 instead. |
This patch changes the integration test suite to use the TestContainers library to provision Vault as Docker containers from the official image. This means that apart from setting up Docker, there are no prerequisites for running the integration tests—just running
./gradlew integrationTests
will provision and tear down Vault servers for the tests.All tests pass on my environment (OS X 10.10.4, Docker For Mac 1.12).
Note that this patch is not without its downsides: