-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L-733 Rebrand Logtail into BetterStack.Logs.NLog #1
Conversation
📣 Logtail is now part of Better Stack. [Learn more ⇗](https://betterstack.com/press/introducing-better-stack/) | ||
|
||
[![Better Stack dashboard](https://github.com/logtail/logtail-python/assets/10132717/e2a1196b-7924-4abc-9b85-055e17b5d499)](https://betterstack.com/logs) | ||
[![Better Stack dashboard](https://raw.githubusercontent.com/BetterStackHQ/logs-client-nlog/main/dashboard.png)](https://betterstack.com/logs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image will start working with merge.
|
||
[![ISC License](https://img.shields.io/badge/license-ISC-ff69b4.svg)](LICENSE.md) | ||
[![Nuget version](https://badge.fury.io/nu/Logtail.svg)](https://www.nuget.org/packages/Logtail) | ||
[![Nuget version](https://badge.fury.io/nu/BetterStack.Logs.NLog.svg)](https://www.nuget.org/packages/BetterStack.Logs.NLog) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Badge will start working with release on nuget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Petr!
Left one nitpick.
</extensions> | ||
|
||
<targets> | ||
<!-- Dont forget to change SOURCE_TOKEN to your actual source token--> | ||
<target xsi:type="Logtail" name="logtail" layout="${message}" sourceToken="SOURCE_TOKEN" /> | ||
<target xsi:type="BetterStack.Logs" name="mybetterstack" layout="${message}" sourceToken="SOURCE_TOKEN" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I would prefer just betterstack
over mybetterstack
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure myself, but wanted to make sure people would understand this is a string they have control over 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That also makes sense - feel free to keep the name whichever way you prefer. 👍
I'm working on detaching NLog dependency from our .NET client (into
BetterStackHQ/logs-client-serilog
), which is a good moment to move our clients out oflogtail
organization and out of beta.Main is currently just a copy of https://github.com/logtail/logtail-dotnet. I've squashed the history to avoid linking historical commits with PR numbers to random newly created PRs.
After merge:
BetterStack.Logs.NLog
as1.0.0
on nuget.org