Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L-733 Rebrand Logtail into BetterStack.Logs.NLog #1

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

PetrHeinz
Copy link
Member

@PetrHeinz PetrHeinz commented Oct 31, 2023

I'm working on detaching NLog dependency from our .NET client (into BetterStackHQ/logs-client-serilog), which is a good moment to move our clients out of logtail organization and out of beta.

Main is currently just a copy of https://github.com/logtail/logtail-dotnet. I've squashed the history to avoid linking historical commits with PR numbers to random newly created PRs.

After merge:

  • Create a tag and release on Github
  • Release BetterStack.Logs.NLog as 1.0.0 on nuget.org
  • Test example project with released nuget
  • Update docs
  • Update Notion instructions for releasing
  • Mark original repo as deprecated + link here

@PetrHeinz PetrHeinz requested a review from curusarn October 31, 2023 14:40
📣 Logtail is now part of Better Stack. [Learn more ⇗](https://betterstack.com/press/introducing-better-stack/)

[![Better Stack dashboard](https://github.com/logtail/logtail-python/assets/10132717/e2a1196b-7924-4abc-9b85-055e17b5d499)](https://betterstack.com/logs)
[![Better Stack dashboard](https://raw.githubusercontent.com/BetterStackHQ/logs-client-nlog/main/dashboard.png)](https://betterstack.com/logs)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image will start working with merge.


[![ISC License](https://img.shields.io/badge/license-ISC-ff69b4.svg)](LICENSE.md)
[![Nuget version](https://badge.fury.io/nu/Logtail.svg)](https://www.nuget.org/packages/Logtail)
[![Nuget version](https://badge.fury.io/nu/BetterStack.Logs.NLog.svg)](https://www.nuget.org/packages/BetterStack.Logs.NLog)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Badge will start working with release on nuget.

Copy link
Contributor

@curusarn curusarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Petr!

Left one nitpick.

</extensions>

<targets>
<!-- Dont forget to change SOURCE_TOKEN to your actual source token-->
<target xsi:type="Logtail" name="logtail" layout="${message}" sourceToken="SOURCE_TOKEN" />
<target xsi:type="BetterStack.Logs" name="mybetterstack" layout="${message}" sourceToken="SOURCE_TOKEN" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would prefer just betterstack over mybetterstack.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure myself, but wanted to make sure people would understand this is a string they have control over 🤷

Copy link
Contributor

@curusarn curusarn Nov 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That also makes sense - feel free to keep the name whichever way you prefer. 👍

@PetrHeinz PetrHeinz merged commit d600635 into main Nov 7, 2023
@PetrHeinz PetrHeinz deleted the ph/rename-to-better-stack branch November 7, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants