U-4293 Catalog and Policies v3 tweaks #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The was an issue with the computed optional metadata value fields item_id, email, and name:
When you saved {type:"User",email:"foo@example.com"}, you would get item_id and name in the response, saving it into state.
This extra state would get saved.
When chasing that value to {type:"String",value:"my string"}, the previously saved item_id and name would be send alongside.
I tried to overcome this issue, but haven't found a way to distinguish the computed optional values from human-configured values.
My solution here is to remove the Computed flag from these fields, and prevent saving the values from API. If this wasn't prevented, the plan after applying would always include the attempt to remove the item_id and name from the value, making the plan unstable.
Fixes both #136 and #137