-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go to Definition and Peek Definition not working on Windows 10 when using WSL #132
Comments
Hello, I am not using Windows so this one quite tricky for me to address. But some time ago @andresrgz fixed another WSL issue... Do you know how this should be fixed, @andresrgz? |
I do have an idea on how to fix this. In the definition.ts file, the Since the repl is running within WSL, that's why the paths are being returned that way. I may have a fix for this some time next week. 🙂 I found this library that will be useful for fixing this problem. |
Cool! Please have a go at it. However, if you can find a solution that does not require a binary installed, that would be extra good. |
@alzadude The PR to fix this has been merged. Maybe you could also help testing it before it gets published? 😄 Just rename the |
Hi @andresrgz, I went to start testing, and I noticed that 1.3.64 must have already been "published" since I see that version number in my VSCode installation. So I tried again, and Some notes:
Thanks for fixing this! |
Yes, it is published. Can you look at 2, @andresrgz ? Regarding the docs. I am pretty sure I have made the wiki editable, so feel free to create pages and edit stuff there. For stuff in the README, PRs are welcome. |
Thanks for your feedback @alzadude, I will reply to each of your points.
Thank you for all of your feedback! |
@alzadude @PEZ @andresrgz This should all be possible with new vscode remote-wsl extension. I tested this setup today with calva version 2.0.49 and it worked correctly. I close this issue for now. |
Hi,
I'm on Windows 10, and I have VSCode configured to use WSL instead of CMD, and so my nrepl gets started with WSL.
However it seems like this breaks
Go to Definition
(F12) andPeek Definition
(Alt+F12)..For example, when I press F12 on a locally defined function in
xxx.clj
, I get a message similar to:Please could this be made to work for WSL? Recent Windows 10 builds have a
wslpath
command that can convert the paths, I was thinking this might help?Thanks!
The text was updated successfully, but these errors were encountered: