Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a fix for issue #132 and also installs the wsl-path library, this does depend on the
wslpath
binary, however that's already included with WSL.Also, since this library was installed, it's now being used to convert the file path that is being sent to Joker. Here's the line of that change.
Finally, the configuration parameter
useJokerOnWSL
was renamed simply touseWSL
, that way the user specifies if the linter and nREPL are both running through WSL.A better solution could've been achieved by instead modifying
cider-nrepl
so that it can return valid Windows paths within WSL. But this is the best I could come up with without modifying the repl dependency. 😄@PEZ You may also want to add the following to the wiki in order to describe how to use this extension with WSL:
Instructions for WSL
If you want to use this extension with WSL, there are a few things that need to be configured first.
useWSL
option must be set totrue
and you must add a valid WSL path to thejokerPath
option.wslpath
tool which is used to convert between WSL and Windows paths.println
,defn
,def
) you will need to change your .m2 directory to a location directly accessible by Windows. For example, you could edit your~/.lein/profiles.clj
like so: