Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use a nightly clojure-lsp #1746

Closed
ericdallo opened this issue May 28, 2022 · 7 comments
Closed

Support use a nightly clojure-lsp #1746

ericdallo opened this issue May 28, 2022 · 7 comments

Comments

@ericdallo
Copy link
Contributor

It'd be really nice if we could tell calva to use the latest nightly build of clojure-lsp, maybe on the same existing setting CLOJURE_LSP_VERSION, when the value is NIGHTLY or something.

The nightly builds area available on github builds, but you can use the link just like here

Thread: https://clojurians.slack.com/archives/C032YH7P0R2/p1653750050858089?thread_ts=1653749719.246089&cid=C032YH7P0R2

@PEZ PEZ mentioned this issue May 29, 2022
16 tasks
@PEZ
Copy link
Collaborator

PEZ commented May 29, 2022

My first attempt trying to implement this failed, when starting. #1750

The binary inside the zip file is not executable. If I chmod +x on it, it starts. I'd rather not have to do this, because Windows and generally just would rather be treating this almost exactly as the other builds. Can you make it so that the binary is executable inside the zip, @ericdallo ?

@ericdallo
Copy link
Contributor Author

I'd love to @PEZ, but it's a GitHub actions issues, the binary loses its permissions when uploading it, there is a open issue with lots of people complaining I can't easily find it right now.
Although, the release binaries have the same issue I think?

@PEZ
Copy link
Collaborator

PEZ commented May 29, 2022

Strangely enough it works with the release builds.

@ericdallo
Copy link
Contributor Author

I think the issue is on the Github Action that upload to the action summary (nightly) not the one that upload to releases

@PEZ
Copy link
Collaborator

PEZ commented May 30, 2022

The server-info for the latest nightly build reports:

"server-version": "2022.05.23-13.18.11",

That's a bit confusing. I was wondering if I am really using the right build. But it also reports:

  "clj-kondo-version": "2022.05.29",

So I guess it is OK.

@ericdallo
Copy link
Contributor Author

Yeah, ATM the nightly build reports the same as the latest release, it'd be nice to show that is a nightly indeed, feel free to create a issue on clojure-lsp for that

@PEZ
Copy link
Collaborator

PEZ commented May 30, 2022

There was an issue already. 😄

PEZ added a commit that referenced this issue May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants