Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline prompt evaluation not visible in Light themes #1855

Closed
marcraminv opened this issue Sep 6, 2022 · 1 comment
Closed

Inline prompt evaluation not visible in Light themes #1855

marcraminv opened this issue Sep 6, 2022 · 1 comment
Labels
bug Something isn't working evaluation regression Regression error ux User experience related

Comments

@marcraminv
Copy link

Context: Trying the Fire Up the Getting REPL

Possible issue: If users prefer Light themes, the inline prompt will not be visible for them

Kapture 2022-09-06 at 09 32 43
@PEZ PEZ added the evaluation label Sep 6, 2022
PEZ added a commit that referenced this issue Sep 6, 2022
@PEZ
Change alpha for inline eval light color
f8c86cb 
Fixes #1855
@PEZ PEZ added bug Something isn't working ux User experience related labels Sep 6, 2022
@PEZ
Copy link
Collaborator

PEZ commented Sep 6, 2022

Thanks! We are using alpha 0 for the color on light themes 🤦

Fix on its way!

@PEZ PEZ added the regression Regression error label Sep 6, 2022
@PEZ PEZ mentioned this issue Sep 6, 2022
Merged
15 tasks
@bpringe bpringe closed this as completed in c7841ab Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working evaluation regression Regression error ux User experience related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PEZ @marcraminv