Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure notebooks don't seem to work on MS-Windows #1994

Closed
ikappaki opened this issue Dec 8, 2022 · 2 comments · Fixed by #1995
Closed

Clojure notebooks don't seem to work on MS-Windows #1994

ikappaki opened this issue Dec 8, 2022 · 2 comments · Fixed by #1995
Labels
bug Something isn't working ms-windows notebooks

Comments

@ikappaki
Copy link
Contributor

ikappaki commented Dec 8, 2022

Hi,

it appears that Clojure notebooks with MS-Windows CRLF line endings are broken, with sexp forms spilling over to the next code block:

image

How to reproduce.

  1. Create a dos.clj file with CRLF endings in any project using the following code
(spit "dos.clj" "(ns dos\r\n  (:require [clojure.string :as str]))\r\n\r\n(str/split \"1 2\" #\" \")")
  1. In VS Code Explorer right click on doc.lj and select Open with... -> Clojure Notebook.
  2. You should get the above break in the first form whose last closing parenthesis spills over to the scond code cell.

PR to follow

@PEZ PEZ added bug Something isn't working notebooks ms-windows labels Dec 8, 2022
@PEZ
Copy link
Collaborator

PEZ commented Dec 8, 2022

Thanks for reporting! ❤️ 🙏 Looking forward to that PR!

@PEZ
Copy link
Collaborator

PEZ commented Dec 16, 2022

We forgot to close this with the commits.

@PEZ PEZ closed this as completed Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ms-windows notebooks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants