Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluating blocking snippets deadlocks the editor #2012

Closed
julienvincent opened this issue Jan 9, 2023 · 0 comments
Closed

Evaluating blocking snippets deadlocks the editor #2012

julienvincent opened this issue Jan 9, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@julienvincent
Copy link
Contributor

If a snippet is evaluated with runCustomREPLCommand and it blocks (due to a bug or some such) then the editor almost completely deadlocks.

I found that running the calva.interruptAllEvaluations resolves the issue but it is still rather unexpected.
julienvincent added a commit to julienvincent/calva that referenced this issue Jan 9, 2023
@julienvincent
Don't block on snippet evaluation
2b2b0ad 
If a snippet is evaluated with runCustomREPLCommand and it blocks (due
to a bug or some such) then the editor almost completely deadlocks.

This commit changes the command handler for `runCustomREPLCommand` to
not block on snippet evaluation.

Fixes BetterThanTomorrow#2012
@julienvincent julienvincent mentioned this issue Jan 9, 2023
Merged
@bpringe bpringe added the bug Something isn't working label Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienvincent @bpringe