Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the indenter to handle the cljfmt 0.11.x breaking config update since version 2.0.383 #2280

Closed
PEZ opened this issue Aug 14, 2023 · 0 comments

Comments

@PEZ
Copy link
Collaborator

PEZ commented Aug 14, 2023

From https://github.com/weavejester/cljfmt/tree/master#breaking-changes-in-011x:

The :indents key has been split into :indents and :extra-indents. The :indents key replaces all default indents, while the :extra-indents key will append to the default indents.

This probably should be mentioned in the Calva docs. Perhaps it calls for an update to the docs more generally to include the :extra-indents, since that is probably the most common configuration from now on.

It also calls for an update of how the Calva indenter reads the configuration. We probably need to recreate the logic now used in cljfmt for this, including the :legacy/merge-indents? escape hatch.

@PEZ PEZ changed the title Update the indenter to handle the **cljfmt** 0.11.x breaking config update Update the indenter to handle the cljfmt 0.11.x breaking config update Aug 14, 2023
PEZ added a commit that referenced this issue Aug 14, 2023
@PEZ PEZ added the regression Regression error label Aug 15, 2023
@PEZ PEZ changed the title Update the indenter to handle the cljfmt 0.11.x breaking config update Update the indenter to handle the cljfmt 0.11.x breaking config update since version 2.0.383 Aug 15, 2023
PEZ added a commit that referenced this issue Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant