Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom command snippets use the wrong ns when repl sessions types do not match #2653

Closed
PEZ opened this issue Oct 21, 2024 · 0 comments
Closed

Custom command snippets use the wrong ns when repl sessions types do not match #2653

PEZ opened this issue Oct 21, 2024 · 0 comments
Labels
bug Something isn't working configuration repl snippets

Comments

@PEZ
Copy link
Collaborator

PEZ commented Oct 21, 2024

When a custom repl command is registered to serve say the clj repl is invoked from a cljs file, and does not have an ns specified, the command will be executed using the ns from the cljs file. Which never makes sense, and will most often break.
@PEZ PEZ added bug Something isn't working repl configuration snippets labels Oct 21, 2024
@PEZ PEZ mentioned this issue Oct 21, 2024
Merged
11 tasks
PEZ added a commit that referenced this issue Oct 21, 2024
@PEZ
Merge pull request #2654 from BetterThanTomorrow/2653-snippet-ns
4f45c5f 
Fixes #2653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working configuration repl snippets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PEZ