Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has Changed?
Currently, there are some numbers that are highlighted wrong by calva:
.
is optional when followed bye
,E
,M
\w
also matches_
which is incorrect.2rABZ
) shouldn't be matched either, but I considered it overkill.constant.numeric.bigint.clojure
intoconstant.numeric.long.clojure
as it doesn't make sense any more to have it separate.constant.numeric.bigdecimal.clojure
intoconstant.numeric.double.clojure
for consistency.After:
Fixes #1378
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.Added to or updated docs in this branch, if appropriateci/circleci: build
test.If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.Created the issue I am fixing/addressing, if it was not present.Ping @PEZ, @bpringe