Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting repl type for cloned cljs session Fixes BetterThanTomorrow/calva#1386 #1439

Conversation

redefn
Copy link
Contributor

@redefn redefn commented Dec 19, 2021

What has Changed?

  • Setting repl type to cljs for out of process nREPL connection. Thanks to that user should be able to switch between cljs/clj repl

Fixes #1386

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.

Ping @PEZ, @bpringe

@PEZ PEZ merged commit c26fc77 into BetterThanTomorrow:dev Dec 19, 2021
@PEZ
Copy link
Collaborator

PEZ commented Dec 19, 2021

Thanks! I have been wondering why that toggling was flaky.

@redefn redefn deleted the bugfix/Connecting-to-an-out-of-process-nREPL branch December 20, 2021 07:43
@redefn
Copy link
Contributor Author

redefn commented Dec 20, 2021

@PEZ calva is a great tool. Thanks a lot for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants