Use platform & architecture to locate clojure-lsp native binary w/ fallback to standalone JAR #1758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has Changed?
Changes the clojure-lsp download logic to use the OS and architecture to find native binary to download and fall back to
clojure-lsp-standalone.jar
for environments with no native binary.Adds support for running clojure-lsp from JAR file.
Tested on linux-amd64, linux-aarch64 (Calva 2.0.280 downloads wrong native binary), windows-aarch64 (no native binary available) and using WSL and SSH remotes.
This PR as-is will change current Calva behavior on M1 Macs by downloading the JAR instead of the native binary which would run under emulation if enabled.
Fixes #1590, #1598
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.ci/circleci: build
test.npm run prettier-format
)npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik