Make REPL prompt reflect current NS reliably #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an evaluation changes the namespace the change is populated back.
PEZ
changed the title
PEZ
reviewed
Sep 23, 2019
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ Changes to Calva. | |||
| - [Support for custom project/workflow commands](https://github.com/BetterThanTomorrow/calva/issues/281) | |||
|
|
|||
| ## [Unreleased] | |||
| - [REPL ns prompt does not change with (ns ..) form](https://github.com/BetterThanTomorrow/calva/issues/280) | |||
There was a problem hiding this comment.
This should reflect what has happened with the change. So either something like what I renamed the PR to, or simply add the word ”Fix” in the beginning.
PEZ
reviewed
Sep 23, 2019
| @@ -169,6 +169,10 @@ class REPLWindow { | |||
| }) | |||
| try { | |||
| this.postMessage({ type: "repl-response", value: await this.evaluation.value, ns: this.ns = ns || this.evaluation.ns || this.ns }); | |||
| if(this.evaluation.ns && this.ns != this.evaluation.ns) { | |||
| // the evaluation changed the namespace so set the new namespace. | |||
| this.setNamespace(this.evaluation.ns); | |||
There was a problem hiding this comment.
Awesome. I have been figuring about this a bit, but obviously not enough to figure this fix out. Thanks!
|
Sweeet! |
|
This works like a charm. It's a bit late here, so I will merge tomorrow, when I am a bit less stupidly tired. 😄 |
|
Among fixes, this one is one of the nicest. It has bothered me a lot that I can't trust the prompt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an evaluation changes the namespace the change is populated back to the REPL window.
This pull request:
Fixes #280.
Introduces the following change(s):
CANGELOG.mdas requestedcalva/repl-window.tsREPLWindow.replEval()method to populate a namespace change from the evaluation back to the repl window.(If you have considered alternative ways to introduce the change, replace this paragrah with a brief reasoning about why you made the choices you did. Otherwise just remove this paragraph.)
I have:
devbranch. (Or have specific reasons to target some other branch.)master. (Sorry for the nagging.)[Unrleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.Ping: @PEZ, @kstehn