Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 391 #392

Merged
merged 5 commits into from
Oct 11, 2019
Merged

Fix issue 391 #392

merged 5 commits into from
Oct 11, 2019

Conversation

cfehse
Copy link
Contributor

@cfehse cfehse commented Oct 11, 2019

Fixes #391.

Introduces the following change(s):

  • Updated package.json to use @types/vscode package in the same version a specified in the engines definition.
  • Removed type/compiler error which was caused by this update in docmirror/index.ts
  • Change URI generation in repl-windows.ts to use the webview.asWebviewUri() method.

I have:

  • Read How to Contribute.
  • Made sure I am directing this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I am changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.

Ping: @PEZ, @kstehn, @cfehse

@PEZ PEZ merged commit 1540186 into BetterThanTomorrow:dev Oct 11, 2019
@cfehse cfehse deleted the fix/issue-391 branch October 12, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants