Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle the clj-kondo extension #426

Merged
merged 8 commits into from
Oct 25, 2019
Merged

Bundle the clj-kondo extension #426

merged 8 commits into from
Oct 25, 2019

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Oct 24, 2019

What has Changed?

  • All listing code is evicted from Calva
  • borkdude.clj-kondo added to the Calva extensionPack.
  • Documentation updated.

Fixes #423

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Made sure I am directing this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I am changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.) You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. (For now you'll need to opt in to the CircleCI New Experience UI to see the Artifacts tab, because bug.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Created the issue I am fixing/addressing, if it was not present.
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

  • Made sure the PR is directed at the dev branch (unless reasons).
  • Read the source changes.
  • Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • If need be, had a chat within the team about particular changes.

Ping @kstehn, @cfehse, @borkdude, @agoldhammer

@borkdude
Copy link

borkdude commented Oct 24, 2019

I would rephrase this a little bit:

One such error could be from not knowing this: Note that the symbols in the clj-kondo configuration need to be fully qualified, with namespaces.
that's not always true, depends on the config per linter, but it's clear from the README

It depends on the linter if symbols in the config are expected to be fully qualified. Some linters expect maps with namespaces to single symbols for example. See https://github.com/borkdude/clj-kondo/blob/master/doc/config.md.

@PEZ
Copy link
Collaborator Author

PEZ commented Oct 25, 2019

There. Fixed it. 😄

@PEZ PEZ merged commit 5059c26 into dev Oct 25, 2019
@PEZ PEZ deleted the bundle-clj-kondo branch October 25, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants