Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refactorings cia clojure-lsp #891

Merged
merged 11 commits into from
Dec 27, 2020
Merged

Add refactorings cia clojure-lsp #891

merged 11 commits into from
Dec 27, 2020

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Dec 25, 2020

What has Changed?

Add the follownig refactorings

Adds:

  • 'clean-ns'
  • 'add-missing-libspec'
  • 'cycle-coll' (Probably Calva's re-wrap commands are better for this)
  • 'cycle-privacy'
  • 'expand-let'
  • 'thread-first'
  • 'thread-first-all'
  • 'thread-last'
  • 'thread-last-all'
  • 'unwind-all'
  • 'unwind-thread'
  • 'introduce-let'
  • 'move-to-let'
  • 'extract-function'

This PR also adds a progress notification fo indicating that the LSP server is unavailable while it is starting.

Fixes #798
Fixes #861
Fixes #892
Fixes #598
Addressing #137

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the default PR base branch, so that it is not master. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.
  • Added to or updated docs in this branch, if appropriate

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

  • Made sure the PR is directed at the dev branch (unless reasons).
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • Read the source changes.
  • Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • If need be, had a chat within the team about particular changes.

Ping @PEZ, @kstehn, @cfehse, @bpringe

PEZ added 4 commits December 25, 2020 14:48
Adds:
* 'clean-ns'
* 'add-missing-libspec'
* 'cycle-coll'
* 'cycle-privacy'
* 'expand-let'
* 'thread-first'
* 'thread-first-all'
* 'thread-last'
* 'thread-last-all'
* 'unwind-all'
* 'unwind-thread'

Fixes #798
Fixes #861
Addressing #137
@PEZ PEZ marked this pull request as ready for review December 26, 2020 00:37
@PEZ PEZ requested a review from bpringe December 26, 2020 00:37
@PEZ PEZ merged commit ad9d880 into dev Dec 27, 2020
@PEZ PEZ deleted the pez/refactorings branch December 27, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant